Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Improve model architecture error message #348

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Improve model architecture error message #348

merged 1 commit into from
Jul 3, 2023

Conversation

viirya
Copy link
Contributor

@viirya viirya commented Jul 3, 2023 •
edited
Loading

When providing an incorrect model architecture:

error: invalid value 'llama1' for '--model-architecture <MODEL_ARCHITECTURE>': llama1 is not one of supported model architectures: [Bloom, Gpt2, GptJ, GptNeoX, Llama, Mpt]

It is much easier for users to know what available model architectures are.

@philpax philpax merged commit 6ce674c into rustformers:main Jul 3, 2023
6 of 9 checks passed
@philpax
Copy link
Collaborator

philpax commented Jul 3, 2023

Congratulations on your first PR! Much appreciated 🚀

@viirya
Copy link
Contributor Author

viirya commented Jul 3, 2023

Thank you for merging my first PR @philpax! 😄

@hhamud hhamud mentioned this pull request Aug 7, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viirya @philpax